hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11974) When a disabled table is scanned, NotServingRegionException is thrown instead of TableNotEnabledException
Date Thu, 18 Sep 2014 21:35:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139558#comment-14139558
] 

stack commented on HBASE-11974:
-------------------------------

Buried in here is a call to the master?

{code}
     RegionLocations rl;
     try {
+      if (!useCache && !tableName.equals(TableName.META_TABLE_NAME) &&
+          RegionReplicaUtil.DEFAULT_REPLICA_ID == replicaId) {
+        HRegionLocation location = cConnection.getRegionLocation(tableName, row, true);
+        return new RegionLocations(location);
+      }
{code}

... because "....locateRegion didn't call isTableEnabled, but relocateRegion did. So replacing
locateRegion with relocateRegion we introduce additional call to isTableEnabled on any retryable
exceptions, right?"

And meta has already been marked that the table is disabled?  We'll not do more rpcs from
the client?

That sounds right to me.  I undo my -1s.

What does 'any retryable exception' mean?  More than just NSRE?



> When a disabled table is scanned, NotServingRegionException is thrown instead of TableNotEnabledException
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11974
>                 URL: https://issues.apache.org/jira/browse/HBASE-11974
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 11974-test.patch, 11974-v1.txt, 11974-v2.txt, 11974-v3.txt, 11974-v4.txt,
11974-v5.txt, 11974-v6.txt
>
>
> When a disabled table is scanned, TableNotEnabledException should be thrown.
> However, currently NotServingRegionException is thrown.
> Thanks to Romil Choksi who discovered this problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message