hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11878) TestVisibilityLabelsWithDistributedLogReplay#testAddVisibilityLabelsOnRSRestart sometimes fails due to VisibilityController not yet initialized
Date Tue, 02 Sep 2014 17:10:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118365#comment-14118365
] 

Sean Busbey commented on HBASE-11878:
-------------------------------------

{code}
@@ -411,7 +412,9 @@ public class VisibilityController extends BaseMasterAndRegionObserver
implements
   @Override
   public RegionScanner preScannerOpen(ObserverContext<RegionCoprocessorEnvironment>
e, Scan scan,
       RegionScanner s) throws IOException {
-    if (!initialized) throw new IOException("VisibilityController not yet initialized!!");
+    if (!initialized) { 
+      throw new VisibilityControllerNotReadyException("VisibilityController not yet initialized!!");
+    }
     HRegion region = e.getEnvironment().getRegion();
     Authorizations authorizations = null;
     try {
{code}

nit: trailing whitespace at the end of the if line.

> TestVisibilityLabelsWithDistributedLogReplay#testAddVisibilityLabelsOnRSRestart sometimes
fails due to VisibilityController not yet initialized
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11878
>                 URL: https://issues.apache.org/jira/browse/HBASE-11878
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 11878-v1.txt, 11878-v2.txt
>
>
> In the thread w.r.t. first RC of 0.98.6, 
> http://search-hadoop.com/m/DHED4p2rw81 , Jean-Marc reported that TestVisibilityLabelsWithDistributedLogReplay#testAddVisibilityLabelsOnRSRestart
sometimes failed on his machines.
> From http://server.distparser.com:81/hbase/with_teds_patch2/hbasetest1/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay-output.txt
:
> {code}
> result {
>   exception {
>     name: "org.apache.hadoop.hbase.coprocessor.CoprocessorException"
>     value: "org.apache.hadoop.hbase.coprocessor.CoprocessorException: VisibilityController
not yet initialized\n\tat org.apache.hadoop.hbase.security.visibility.VisibilityController.addLabels(VisibilityController.java:638)\n\tat
org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$VisibilityLabelsService$1.addLabels(VisibilityLabelsProtos.java:5014)\n\tat
org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$VisibilityLabelsService.callMethod(VisibilityLabelsProtos.java:5178)\n\tat
org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:5794)\n\tat org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1608)\n\tat
org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1590)\n\tat
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:30088)\n\tat
org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2014)\n\tat org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:98)\n\tat
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:114)\n\tat org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:94)\n\tat
java.lang.Thread.run(Thread.java:744)\n"
>   }
> }
> {code}
> The above exception revealed a race condition: writing of labels "ABC" and  "XYZ" took
place when VisibilityController was not yet initialized.
> The test writes the labels only once, leading to assertion failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message