hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liu Shaohui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11877) Make TableSplit more readable
Date Wed, 03 Sep 2014 06:18:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119435#comment-14119435
] 

Liu Shaohui commented on HBASE-11877:
-------------------------------------

[~jmspaggi] [~stack]
{quote}
Don't see any issue with that. Have you ran it locally? Do you have a copy of the output?

{quote}
The split output from TestCopyTable
{code}
2014-09-03 13:42:55,180 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: HBase
table split(table name: testStartStopRow1, start row: row1, end row: row2, region location:
localhost)
{code}

{quote}
Has it passed the tests? 
{quote}
Yes, all tests passed in my dev machine
{quote}
Not anyrisk for those new fields (m_tableName, m_regionLocation) to be null?
{quote}
The append method of StringBuilder and Bytes.toStringBinary have handled the null object situation.
If the object is null, the method will transform it to string "null".

> Make TableSplit more readable
> -----------------------------
>
>                 Key: HBASE-11877
>                 URL: https://issues.apache.org/jira/browse/HBASE-11877
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-11877-trunk-v1.diff
>
>
> When debugging MR jobs reading from hbase table, it's import to figure out which region
a map task is reading from.
> But the table split object is hard to read.
> eg:
> {code}
> 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split:
lg-hadoop-prc-st40.bj:,0
> {code}
> See: TableSplit.java 
> {code}
>   @Override
>   public String toString() {
>     return m_regionLocation + ":" +
>       Bytes.toStringBinary(m_startRow) + "," + Bytes.toStringBinary(m_endRow);
>   }
> {code}
> We should make it more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message