hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11876) RegionScanner.nextRaw(...) should not update metrics
Date Wed, 03 Sep 2014 19:10:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120280#comment-14120280
] 

Hudson commented on HBASE-11876:
--------------------------------

FAILURE: Integrated in HBase-0.98 #494 (See [https://builds.apache.org/job/HBase-0.98/494/])
Revert "HBASE-11876 RegionScanner.nextRaw should not update metrics" (apurtell: rev c3882ed73a5c77c21ee5110ded9598f2f317cb55)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
HBASE-11876 RegionScanner.nextRaw should not update metrics (apurtell: rev cf843b196338cf2f2bd0eafbe88fda7d4386fba2)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java


> RegionScanner.nextRaw(...) should not update metrics
> ----------------------------------------------------
>
>                 Key: HBASE-11876
>                 URL: https://issues.apache.org/jira/browse/HBASE-11876
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.6
>            Reporter: Lars Hofhansl
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: HBASE-11876-0.98.patch, HBASE-11876-0.98.patch, HBASE-11876.patch,
HBASE-11876.patch
>
>
> I added the RegionScanner.nextRaw(...) to allow "smart" client to avoid some of the default
work that HBase is doing, such as {start|stop}RegionOperation and synchronized(scanner) for
each row.
> Metrics should follow the same approach. Collecting them per row is expensive and a caller
should have the option to collect those later or to avoid collecting them completely.
> We can also save some cycles in RSRcpServices.scan(...) if we updated the metric only
once/batch instead of each row.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message