hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11876) RegionScanner.nextRaw(...) should not update metrics
Date Wed, 03 Sep 2014 15:34:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119973#comment-14119973
] 

Andrew Purtell commented on HBASE-11876:
----------------------------------------

There are two code paths in 0.98 which call nextRaw from scanning code. One isn't found by
Eclipse reference search but grep did the trick. Will revert previous commit and push the
fixed version as soon as local tests check out.

> RegionScanner.nextRaw(...) should not update metrics
> ----------------------------------------------------
>
>                 Key: HBASE-11876
>                 URL: https://issues.apache.org/jira/browse/HBASE-11876
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.6
>            Reporter: Lars Hofhansl
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: HBASE-11876-0.98.patch, HBASE-11876.patch, HBASE-11876.patch
>
>
> I added the RegionScanner.nextRaw(...) to allow "smart" client to avoid some of the default
work that HBase is doing, such as {start|stop}RegionOperation and synchronized(scanner) for
each row.
> Metrics should follow the same approach. Collecting them per row is expensive and a caller
should have the option to collect those later or to avoid collecting them completely.
> We can also save some cycles in RSRcpServices.scan(...) if we updated the metric only
once/batch instead of each row.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message