hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11876) RegionScanner.nextRaw(...) should not update metrics
Date Tue, 02 Sep 2014 22:29:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118848#comment-14118848
] 

Hadoop QA commented on HBASE-11876:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org
  against trunk revision .
  ATTACHMENT ID: http:

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10685//console

This message is automatically generated.

> RegionScanner.nextRaw(...) should not update metrics
> ----------------------------------------------------
>
>                 Key: HBASE-11876
>                 URL: https://issues.apache.org/jira/browse/HBASE-11876
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.6
>            Reporter: Lars Hofhansl
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>
> I added the RegionScanner.nextRaw(...) to allow "smart" client to avoid some of the default
work that HBase is doing, such as {start|stop}RegionOperation and synchronized(scanner) for
each row.
> Metrics should follow the same approach. Collecting them per row is expensive and a caller
should have the option to collect those later or to avoid collecting them completely.
> We can also save some cycles in RSRcpServices.scan(...) if we updated the metric only
once/batch instead of each row.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message