hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11874) Support Cell to be passed to StoreFile.Writer rather than KeyValue
Date Mon, 01 Sep 2014 13:12:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117404#comment-14117404
] 

Anoop Sam John commented on HBASE-11874:
----------------------------------------

We deal with key as single buffer in HFileWriter and DBEs. A Cell coming in would make us
to recreate the key and copy rk, cf, qualifier, ts and type bytes. 
One way to solve this copy is to make a new Interface which contains getKeyArray(), getKeyOffset(),
getKeyLength() APIs. The impls like KeyValue,  where we have single buffer for the key can
implement this Interface. In Writer we can directly get the key when Cell is instance of this
new interface. Else we can make the key. We can have a util API in CellUtil to make the key
from Cell.


> Support Cell to be passed to StoreFile.Writer rather than KeyValue
> ------------------------------------------------------------------
>
>                 Key: HBASE-11874
>                 URL: https://issues.apache.org/jira/browse/HBASE-11874
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0
>
>
> This is the in write path and touches StoreFile.Writer,  HFileWriter , HFileDataBlockEncoder
and different DataBlockEncoder impl.
> We will have to avoid KV#getBuffer() KV#getKeyOffset/Length() calls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message