hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
Date Tue, 02 Sep 2014 19:05:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118553#comment-14118553
] 

stack commented on HBASE-11826:
-------------------------------

[~carterpage] [~anoop.hbase] is just pointing out that after this patch goes in, we can remove
the deprecated methods (in new issue) in trunk.  Makes sense to me.  Lets get this into branch-1
and master first.  @enis and [~ndimiduk], you fellas good w/ this?  Will commit tomorrow unless
objection.

> Split each tableOrRegionName admin methods into two targetted methods
> ---------------------------------------------------------------------
>
>                 Key: HBASE-11826
>                 URL: https://issues.apache.org/jira/browse/HBASE-11826
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Carter
>            Assignee: Carter
>         Attachments: HBASE_11826.patch, HBASE_11826_v2.patch, HBASE_11826_v2.patch
>
>
> Purpose of this is two implement [~enis]'s suggestion to strongly type the methods that
take "tableOrRegionName" as an argument.
> For instance:
> {code}
> void compact(final String tableNameOrRegionName)
> void compact(final byte[] tableNameOrRegionName)
> {code}
> becomes
> {code}
> @Deprecated
> void compact(final String tableNameOrRegionName)
> @Deprecated
> void compact(final byte[] tableNameOrRegionName)
> void compact(TableName table)
> void compactRegion(final byte[] regionName)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message