hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11679) Replace "HTable" with "HTableInterface" where backwards-compatible
Date Tue, 09 Sep 2014 21:17:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127572#comment-14127572
] 

Hudson commented on HBASE-11679:
--------------------------------

FAILURE: Integrated in HBase-1.0 #167 (See [https://builds.apache.org/job/HBase-1.0/167/])
HBASE-11679 Replace HTable with HTableInterface where backwards-compatible (Carter) (enis:
rev b175042917f88aebcffa2b554da73273620af5b1)
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestLazyCfLoading.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionKeyRotation.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/HRegionPartitioner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotCloneIndependence.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestImportTsv.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithVisibilityLabels.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverBypass.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java
* hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerWithBulkload.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionRandomKeying.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicaWithCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTimestampsFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestHTableWrapper.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHBaseAdminNoCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/ScanPerformanceEvaluation.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/fs/TestBlockReorder.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestPutWithDelete.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableUtil.java
* hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestRowCountEndpoint.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerOnCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/trace/TestHTraceHooks.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestPerTableCFReplication.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCopyTable.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTree.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceBase.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduceUtil.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLs.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessor.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSCVFWithMiniCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java
* hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestBulkDeleteProtocol.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerObserver.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationWithTags.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterWithScanLimits.java
* hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromAdmin.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterTransitions.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
* hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMultiSlaveReplication.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSizeCalculator.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSyncUpTool.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithSLGStack.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithOperationAttributes.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALPlayer.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckEncryption.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionOnCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestNamespaceCommands.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestOpenTableInCoprocessor.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestChangingEncoding.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HMerge.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessControlFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityClient.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotMetadata.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMultithreadedTableMapper.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogFiltering.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
* hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestZooKeeperScanPolicyObserver.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientOperationInterrupt.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellCounter.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReader.java
* hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithLabels.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowAndColumnRangeFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientScannerRPCTimeout.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionSizeCalculator.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithACL.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestGzipFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredNodeAssignmentHelper.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollPeriod.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowResource.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestEnforcingScanLabelGenerator.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestProcessBasedCluster.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedListWithVisibility.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestColumnRangeFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterWrapper.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestBatchCoprocessorEndpoint.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultipleTimestamps.java
* hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestTimeBoundedRequestsWithRegionReplicas.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestScanEarlyTermination.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java


> Replace "HTable" with "HTableInterface" where backwards-compatible
> ------------------------------------------------------------------
>
>                 Key: HBASE-11679
>                 URL: https://issues.apache.org/jira/browse/HBASE-11679
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Carter
>            Assignee: Carter
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: HBASE_11679.patch, HBASE_11679.patch, HBASE_11679_v3.patch, HBASE_11679_v4.patch,
HBASE_11679_v5.patch, hbase-11679_v6-branch-1.patch, hbase-11679_v6.patch
>
>
> This is a refactor to move more of the code towards using interfaces for proper encapsulation
of logic.
> The amount of code touched is large, but it should be fairly easy to review.  It changes
variable declarations from HTable to HTableInterface where the following holds:
> # The declaration being updated won't break assignment
> # The declaration change does not break the compile (eg trying to access non-interface
methods)
> The two main situations are to change something like this:
> {code}
> HTable h = new HTable(c, tn);
> {code}
> to
> {code}
> HTableInterface h = new HTable(c, tn);
> {code}
> and this:
> {code}
> public void doSomething(HTable h) { ... }
> {code}
> to this:
> {code}
> public void doSomething(HTableInterface h) { ... }
> {code}
> This gets most of the obvious cases out of the way and prepares for more complicated
interface refactors in the future.  In method signatures, I changed parameters, but did _not_
change any public or protected method return values, since that would violate criteria #1
above and break compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message