hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11679) Replace "HTable" with "HTableInterface" where backwards-compatible
Date Fri, 05 Sep 2014 15:33:28 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123049#comment-14123049
] 

Hadoop QA commented on HBASE-11679:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12666804/HBASE_11679_v4.patch
  against trunk revision .
  ATTACHMENT ID: 12666804

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 495 new or modified
tests.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail.

    Compilation errors resume:
    [ERROR] COMPILATION ERROR : 
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java:[84,8]
error: method render in class MasterStatusTmpl cannot be applied to given types;
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
(default-compile) on project hbase-server: Compilation failure
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java:[84,8]
error: method render in class MasterStatusTmpl cannot be applied to given types;
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hbase-server
    

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10725//console

This message is automatically generated.

> Replace "HTable" with "HTableInterface" where backwards-compatible
> ------------------------------------------------------------------
>
>                 Key: HBASE-11679
>                 URL: https://issues.apache.org/jira/browse/HBASE-11679
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Carter
>            Assignee: Carter
>         Attachments: HBASE_11679.patch, HBASE_11679.patch, HBASE_11679_v3.patch, HBASE_11679_v4.patch
>
>
> This is a refactor to move more of the code towards using interfaces for proper encapsulation
of logic.
> The amount of code touched is large, but it should be fairly easy to review.  It changes
variable declarations from HTable to HTableInterface where the following holds:
> # The declaration being updated won't break assignment
> # The declaration change does not break the compile (eg trying to access non-interface
methods)
> The two main situations are to change something like this:
> {code}
> HTable h = new HTable(c, tn);
> {code}
> to
> {code}
> HTableInterface h = new HTable(c, tn);
> {code}
> and this:
> {code}
> public void doSomething(HTable h) { ... }
> {code}
> to this:
> {code}
> public void doSomething(HTableInterface h) { ... }
> {code}
> This gets most of the obvious cases out of the way and prepares for more complicated
interface refactors in the future.  In method signatures, I changed parameters, but did _not_
change any public or protected method return values, since that would violate criteria #1
above and break compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message