hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dima Spivak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11628) Clean up tests that expect an exception
Date Sun, 14 Sep 2014 20:02:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133366#comment-14133366
] 

Dima Spivak commented on HBASE-11628:
-------------------------------------

I'd like to work on this next week, if that's alright. I'm really excited about getting more
familiar with our unit tests in general and committing myself to this seems like good motivation.
:)

> Clean up tests that expect an exception
> ---------------------------------------
>
>                 Key: HBASE-11628
>                 URL: https://issues.apache.org/jira/browse/HBASE-11628
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Dima Spivak
>            Priority: Trivial
>              Labels: beginner
>
> We have a few tests that look for expected exceptions by manually catching and explicitly
failing in case no exception happens.
> Places that need to be fixed can be found by running:
> {code}
>   $> grep -rie "[^n]expected *exception" `find . -name test -path '*/src/*' -type
d | xargs`
> {code}
> (there are some false positives, e.g. TestIPv6NIOServerSocketChannel)
> We should clean these up to use [JUnit's expected arg to the Test annotation|http://junit.org/javadoc/4.11/org/junit/Test.html#expected()].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message