hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11462) MetaTableAccessor shouldn't use ZooKeeeper
Date Sun, 14 Sep 2014 11:40:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133172#comment-14133172
] 

Hadoop QA commented on HBASE-11462:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12668646/HBASE-11462.v2.patch
  against trunk revision .
  ATTACHMENT ID: 12668646

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 18 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestMasterFailover
                  org.apache.hadoop.hbase.client.TestReplicaWithCluster
                  org.apache.hadoop.hbase.replication.TestPerTableCFReplication
                  org.apache.hadoop.hbase.master.TestAssignmentListener

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s): 	at org.apache.hadoop.hbase.mapreduce.TestImportTsv.testBulkOutputWithTsvImporterTextMapper(TestImportTsv.java:229)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10878//console

This message is automatically generated.

> MetaTableAccessor shouldn't use ZooKeeeper
> ------------------------------------------
>
>                 Key: HBASE-11462
>                 URL: https://issues.apache.org/jira/browse/HBASE-11462
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, Zookeeper
>    Affects Versions: 2.0.0
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11462.v1.patch, HBASE-11462.v2.patch
>
>
> After committing patch for HBASE-4495, there's an further improvement which can be made
(discussed originally on review board to that jira).
> We have MetaTableAccessor and MetaTableLocator classes. First one is used to access information
stored in hbase:meta table. Second one is used to deal with ZooKeeper state to find out region
server hosting hbase:meta, wait for it to become available and so on.
> MetaTableAccessor, in turn, should only operate on the meta table content, so shouldn't
need ZK. The only reason why MetaTableAccessor is using ZK - when callers request assignment
information, they can request location of meta table itself, which we can't read from meta,
so in that case MetaTableAccessor relays the call to MetaTableLocator.  May be the solution
here is to declare that clients of MetaTableAccessor shall not use it to work with meta table
itself (not it's content).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message