hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11405) Multiple invocations of hbck in parallel disables balancer permanently
Date Thu, 18 Sep 2014 00:05:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138243#comment-14138243
] 

Hudson commented on HBASE-11405:
--------------------------------

FAILURE: Integrated in HBase-1.0 #194 (See [https://builds.apache.org/job/HBase-1.0/194/])
HBASE-11405 Multiple invocations of hbck in parallel disables balancer permanently (Bharath
Vissapragada) (jmhsieh: rev 3b30a104247e65b6443bc94545235d789cf13185)
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
Revert "HBASE-11405 Multiple invocations of hbck in parallel disables balancer permanently
(Bharath Vissapragada)" (jmhsieh: rev 27eaba2539f5f09ba2cbd66f3c1c3bbe66403032)
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java


> Multiple invocations of hbck in parallel disables balancer permanently 
> -----------------------------------------------------------------------
>
>                 Key: HBASE-11405
>                 URL: https://issues.apache.org/jira/browse/HBASE-11405
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer, hbck
>    Affects Versions: 0.99.0
>            Reporter: bharath v
>            Assignee: bharath v
>             Fix For: 2.0.0, 0.99.1
>
>         Attachments: 11405-v3.txt, 11405-v5.patch, 11405-v6.patch, HBASE-11405-trunk-rebased.patch,
HBASE-11405-trunk.patch, HBASE-11405-trunk.patch.1, hbase-11405.rebase.140911.patch
>
>
> This is because of the following piece of code in hbck
> {code:borderStyle=solid}
>   boolean oldBalancer = admin.setBalancerRunning(false, true);
>     try {
>       onlineConsistencyRepair();
>     }
>     finally {
>       admin.setBalancerRunning(oldBalancer, false);
>     }
> {code}
> Newer invocations set oldBalancer to false as it was disabled by previous invocations
and this disables balancer permanently unless its manually turned on by the user. Easy to
reproduce, just run hbck 100 times in a loop in 2 different sessions and you can see that
balancer is set to false in the HMaster logs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message