hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bharath v (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-11405) Multiple invocations of hbck in parallel disables balancer permanently
Date Mon, 15 Sep 2014 15:29:37 GMT

     [ https://issues.apache.org/jira/browse/HBASE-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

bharath v updated HBASE-11405:
------------------------------
    Attachment: 11405-v6.patch

v6 summary

- Moved unlockHbck() from exec() to onlineHbck() method, since some of the tests directly
call onlineHbck() rather than going via exec. This makes sure we cleanup the lock in tests
- Small bug in compareAndSet(), misread the doc, fixed it, also setting it to (false) inside
the block to make sure tests using the same HBck object doesn't fail.

> Multiple invocations of hbck in parallel disables balancer permanently 
> -----------------------------------------------------------------------
>
>                 Key: HBASE-11405
>                 URL: https://issues.apache.org/jira/browse/HBASE-11405
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer, hbck
>    Affects Versions: 0.99.0
>            Reporter: bharath v
>            Assignee: bharath v
>         Attachments: 11405-v3.txt, 11405-v5.patch, 11405-v6.patch, HBASE-11405-trunk-rebased.patch,
HBASE-11405-trunk.patch, HBASE-11405-trunk.patch.1, hbase-11405.rebase.140911.patch
>
>
> This is because of the following piece of code in hbck
> {code:borderStyle=solid}
>   boolean oldBalancer = admin.setBalancerRunning(false, true);
>     try {
>       onlineConsistencyRepair();
>     }
>     finally {
>       admin.setBalancerRunning(oldBalancer, false);
>     }
> {code}
> Newer invocations set oldBalancer to false as it was disabled by previous invocations
and this disables balancer permanently unless its manually turned on by the user. Easy to
reproduce, just run hbck 100 times in a loop in 2 different sessions and you can see that
balancer is set to false in the HMaster logs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message