hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11290) Unlock RegionStates
Date Fri, 12 Sep 2014 21:01:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132101#comment-14132101
] 

Mikhail Antonov commented on HBASE-11290:
-----------------------------------------

Also 

 - in AM, #addPlan() grabs locks for region name before putting into regionPlans, but #addPlans()
doesn't get any locks? It assumed the lock is already grabbed for all those regions?
 - in #processServerShutdown we don't need locks on regionPlans?


> Unlock RegionStates
> -------------------
>
>                 Key: HBASE-11290
>                 URL: https://issues.apache.org/jira/browse/HBASE-11290
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Francis Liu
>            Assignee: Virag Kothari
>         Attachments: HBASE-11290-0.98.patch, HBASE-11290.draft.patch
>
>
> Even though RegionStates is a highly accessed data structure in HMaster. Most of it's
methods are synchronized. Which limits concurrency. Even simply making some of the getters
non-synchronized by using concurrent data structures has helped with region assignments. We
can go as simple as this approach or create locks per region or a bucket lock per region bucket.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message