hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10841) Scan,Get,Put,Delete,etc setters should consistently return this
Date Sat, 06 Sep 2014 04:34:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124306#comment-14124306
] 

Hudson commented on HBASE-10841:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #5472 (See [https://builds.apache.org/job/HBase-TRUNK/5472/])
HBASE-10841 Scan,Get,Put,Delete,etc setters should consistently return this (enis: rev 34a5019b426c7bc05422e5549cdf56b5e4d7c6e0)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Get.java
* hbase-shell/src/main/ruby/hbase/table.rb
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestOperation.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Attributes.java


> Scan,Get,Put,Delete,etc setters should consistently return this
> ---------------------------------------------------------------
>
>                 Key: HBASE-10841
>                 URL: https://issues.apache.org/jira/browse/HBASE-10841
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, Usability
>    Affects Versions: 0.99.0
>            Reporter: Nick Dimiduk
>            Assignee: Enis Soztutar
>            Priority: Minor
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: hbase-10841_v1.patch, hbase-10841_v1.patch, hbase-10841_v2.patch,
hbase-10841_v3.patch
>
>
> While addressing review comments on HBASE-10818, I noticed that our {{Scan}} class is
inconsistent with it's setter methods. Some of them return {{this}}, other's don't. They should
be consistent. I suggest making them all return {{this}}, to support chained invocation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message