hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-10841) Scan setters should consistently return this
Date Wed, 03 Sep 2014 02:53:52 GMT

     [ https://issues.apache.org/jira/browse/HBASE-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Enis Soztutar updated HBASE-10841:
----------------------------------
    Attachment: hbase-10841_v1.patch

Here is a patch which fixes all offenders in Put,Delete,Get,Scan,etc. Also has a unit test
to check methods added later. 

This breaks binary compat between 0.98 and master/0.99, but as per previous threads, it should
be fine to break binary compat between major releases as long as wire compat (rolling restarts)
is kept. 



> Scan setters should consistently return this
> --------------------------------------------
>
>                 Key: HBASE-10841
>                 URL: https://issues.apache.org/jira/browse/HBASE-10841
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, Usability
>    Affects Versions: 0.99.0
>            Reporter: Nick Dimiduk
>            Assignee: Enis Soztutar
>            Priority: Minor
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: hbase-10841_v1.patch
>
>
> While addressing review comments on HBASE-10818, I noticed that our {{Scan}} class is
inconsistent with it's setter methods. Some of them return {{this}}, other's don't. They should
be consistent. I suggest making them all return {{this}}, to support chained invocation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message