hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10841) Scan,Get,Put,Delete,etc setters should consistently return this
Date Thu, 04 Sep 2014 19:02:54 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121772#comment-14121772
] 

Hadoop QA commented on HBASE-10841:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12666538/hbase-10841_v1.patch
  against trunk revision .
  ATTACHMENT ID: 12666538

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10714//console

This message is automatically generated.

> Scan,Get,Put,Delete,etc setters should consistently return this
> ---------------------------------------------------------------
>
>                 Key: HBASE-10841
>                 URL: https://issues.apache.org/jira/browse/HBASE-10841
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, Usability
>    Affects Versions: 0.99.0
>            Reporter: Nick Dimiduk
>            Assignee: Enis Soztutar
>            Priority: Minor
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: hbase-10841_v1.patch, hbase-10841_v1.patch
>
>
> While addressing review comments on HBASE-10818, I noticed that our {{Scan}} class is
inconsistent with it's setter methods. Some of them return {{this}}, other's don't. They should
be consistent. I suggest making them all return {{this}}, to support chained invocation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message