hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10576) Custom load balancer to co-locate the regions of two tables which are having same split keys
Date Thu, 04 Sep 2014 23:03:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122141#comment-14122141
] 

Ted Yu commented on HBASE-10576:
--------------------------------

{code}
+    if (this.offLine == o.offLine) {
+      if(this.shadow == o.shadow) return 0;
+      if (this.shadow == true) return -1;
{code}
Why is check of shadow tied to offline status ?
{code}
+  public static void shadowRegion(final HConnection hConnection, HRegionInfo region, ServerName
sn)
+      throws IOException {
{code}
Can you add javadoc for the above method ?
{code}
+      byte[] tableRow = Bytes.toBytes(region.getRegionNameAsString() + HConstants.DELIMITER);
{code}
What's the purpose for adding trailing delimiter ?

Reviewboard would be handy for reviewers.

> Custom load balancer to co-locate the regions of two tables which are having same split
keys
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10576
>                 URL: https://issues.apache.org/jira/browse/HBASE-10576
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Balancer
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>         Attachments: HBASE-10536_v2.patch, HBASE-10576.patch, HBASE-10576_shadow_regions_wip.patch
>
>
> To support local indexing both user table and index table should have same split keys.
This issue to provide custom balancer to colocate the regions of two tables which are having
same split keys. 
> This helps in Phoenix as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message