Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 31 Aug 2014 10:28:53 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12736700.1409026401224.10826.1409480933731@arcas>
In-Reply-To: <JIRA.12736700.1409026401224@arcas>
References: <JIRA.12736700.1409026401224@arcas>
Subject: [jira] [Commented] (HBASE-11821) [ImportTSV] Abstract labels tags
 creation into pluggable Interface
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116696#comment-14116696 ] 

Hadoop QA commented on HBASE-11821:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12665600/HBASE-11821_V4.patch
  against trunk revision .
  ATTACHMENT ID: 12665600

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestDistributedLogSplitting

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10660//console

This message is automatically generated.

> [ImportTSV] Abstract labels tags creation into pluggable Interface
> ------------------------------------------------------------------
>
>                 Key: HBASE-11821
>                 URL: https://issues.apache.org/jira/browse/HBASE-11821
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce, security
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.7
>
>         Attachments: HBASE-11821.patch, HBASE-11821_V3.patch, HBASE-11821_V4.patch
>
>
> HBASE-11553 abstracted out the VisibilityLabelService and using which one can go with String based labels tags instead of default ordinal based. In MapReduce side, ImportTSV also should support such an abstraction layer.  This is applicable for HFileOutputFormat where mappers create Cells to be written to HFiles. 
> Also every Mapper (custom written also) dealing with such low level HBase things (Creation of tags and Cells) is not a good idea. This issue plan to provide a public audience Facade class to facilitate such Cell creation so that Mappers can just make use of them.


--
This message was sent by Atlassian JIRA
(v6.2#6252)