Return-Path: 
 <issues-return-158773-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DCF381149C
	for <apmail-hbase-issues-archive@www.apache.org>;
 Mon, 25 Aug 2014 10:03:59 +0000 (UTC)
Received: (qmail 16526 invoked by uid 500); 25 Aug 2014 10:03:59 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 16483 invoked by uid 500); 25 Aug 2014 10:03:59 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 16470 invoked by uid 99); 25 Aug 2014 10:03:59 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Aug 2014 10:03:59 +0000
Date: Mon, 25 Aug 2014 10:03:59 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12736121.1408731865600.2546.1408961039602@arcas>
In-Reply-To: <JIRA.12736121.1408731865600@arcas>
References: <JIRA.12736121.1408731865600@arcas>
Subject: [jira] [Commented] (HBASE-11805) KeyValue to Cell Convert in
 WALEdit APIs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108974#comment-14108974 ] 

Anoop Sam John commented on HBASE-11805:
----------------------------------------

WALEdit implements HeapSize, and as Cell is not having heapSize() we will ending up in issue.
Also will have to have the setSeqId() which is there only in KeyValue
KeyValue#length() is the other one which is used by/from WALEdit.

The background of this is, we need different type of Tag which only has to go into WAL, then if the WALEdit add takes KV only, we have to recreate a KV which needs byte copying for entire KV key, value etc.  If we have WALEdit#add(Cell) we can create a new Cell impl where the Key and Value part refer to the same byte[] and tags part only needs a byte[] copy and recreation.

Any ideas for the extension of Cell?  [~stack], [~ram_krish]

> KeyValue to Cell Convert in WALEdit APIs
> ----------------------------------------
>
>                 Key: HBASE-11805
>                 URL: https://issues.apache.org/jira/browse/HBASE-11805
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>
> In almost all other main interface class/APIs we have changed KeyValue to Cell. But missing in WALEdit. This is public marked for Replication (Well it should be for CP also) 
> These 2 APIs deal with KVs
> add(KeyValue kv)
> ArrayList<KeyValue> getKeyValues()
> Suggest deprecate them and add for 0.98
> add(Cell kv) 
> List<Cell> getCells()
> And just replace from 1.0



--
This message was sent by Atlassian JIRA
(v6.2#6252)