Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C7A411637 for ; Fri, 22 Aug 2014 21:16:12 +0000 (UTC) Received: (qmail 87974 invoked by uid 500); 22 Aug 2014 21:16:12 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 87928 invoked by uid 500); 22 Aug 2014 21:16:12 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 87916 invoked by uid 99); 22 Aug 2014 21:16:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Aug 2014 21:16:12 +0000 Date: Fri, 22 Aug 2014 21:16:11 +0000 (UTC) From: "Jean-Marc Spaggiari (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11794) StripeStoreFlusher causes NullPointerException and Region down MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107500#comment-14107500 ] Jean-Marc Spaggiari commented on HBASE-11794: --------------------------------------------- List is initialized empty. So even on failure, it will be returned empty, no? > StripeStoreFlusher causes NullPointerException and Region down > -------------------------------------------------------------- > > Key: HBASE-11794 > URL: https://issues.apache.org/jira/browse/HBASE-11794 > Project: HBase > Issue Type: Bug > Components: Compaction > Affects Versions: 0.98.3, 0.98.4, 0.98.5 > Reporter: jeongmin kim > Priority: Critical > Attachments: HBASE_11794.patch > > > StoreFlusher.flushSnapshot() mustn't return null value. > But StripeStoreFlusher.flushSnapshot() does. > It cause NullPointerException at org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:802) > and this makes regions dead after exhaustive retries and no recovery available from it. > the code (StripeStoreFlusher:64) has to be changed > =============== > from > List result = null > to > List result = new ArrayList(); > =============== > to return a empty list not null value. > -- This message was sent by Atlassian JIRA (v6.2#6252)