Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1660C11D9D for ; Wed, 20 Aug 2014 00:33:20 +0000 (UTC) Received: (qmail 43335 invoked by uid 500); 20 Aug 2014 00:33:19 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 43295 invoked by uid 500); 20 Aug 2014 00:33:19 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 43281 invoked by uid 99); 20 Aug 2014 00:33:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Aug 2014 00:33:19 +0000 Date: Wed, 20 Aug 2014 00:33:19 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11774) Avoid allocating unnecessary tag iterators MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103144#comment-14103144 ] Hudson commented on HBASE-11774: -------------------------------- FAILURE: Integrated in HBase-1.0 #113 (See [https://builds.apache.org/job/HBase-1.0/113/]) HBASE-11774 Avoid allocating unnecessary tag iterators (apurtell: rev f3f39473977682c5a968f57937d28d1eec041759) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java > Avoid allocating unnecessary tag iterators > ------------------------------------------ > > Key: HBASE-11774 > URL: https://issues.apache.org/jira/browse/HBASE-11774 > Project: HBase > Issue Type: Improvement > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Minor > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: HBASE-11774.patch, HBASE-11774_v2-0.98.patch, HBASE-11774_v2.patch > > > We can avoid an unnecessary object allocation, sometimes in hot code paths, by not creating a tag iterator if the cell's tag area is of length zero, signifying no tags present. -- This message was sent by Atlassian JIRA (v6.2#6252)