Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 25 Aug 2014 05:57:58 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12734570.1408159372414.1344.1408946278779@arcas>
In-Reply-To: <JIRA.12734570.1408159372414@arcas>
References: <JIRA.12734570.1408159372414@arcas>
Subject: [jira] [Commented] (HBASE-11766) Backdoor CoprocessorHConnection is
 no longer being used for local writes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108775#comment-14108775 ] 

ramkrishna.s.vasudevan commented on HBASE-11766:
------------------------------------------------

Seeing the reasoning given by [~jeffreyz], the patch seems to be right.  Looks good to me. +1.

> Backdoor CoprocessorHConnection is no longer being used for local writes
> ------------------------------------------------------------------------
>
>                 Key: HBASE-11766
>                 URL: https://issues.apache.org/jira/browse/HBASE-11766
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.4
>            Reporter: James Taylor
>            Assignee: Andrew Purtell
>              Labels: Phoenix
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: HBASE-11766.patch, HBASE-11766.patch
>
>
> There's a backdoor CoprocessorHConnection used to ensure that a batched mutation does not go over the wire and back, but executes immediately locally. This is leveraged by Phoenix during secondary index maintenance (for an ~20% perf improvement). It looks to me like it's no longer used, as the following function is never invoked:
>   public org.apache.hadoop.hbase.protobuf.generated.ClientProtos.ClientService.BlockingInterface
>       getClient(ServerName serverName) throws IOException {
> It'd be good if feasible to add an HBase unit test to prevent further regressions. For more info, see PHOENIX-1166.


--
This message was sent by Atlassian JIRA
(v6.2#6252)