Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 586E011E2D for ; Sat, 9 Aug 2014 05:23:13 +0000 (UTC) Received: (qmail 24483 invoked by uid 500); 9 Aug 2014 05:23:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 24428 invoked by uid 500); 9 Aug 2014 05:23:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 24415 invoked by uid 99); 9 Aug 2014 05:23:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Aug 2014 05:23:12 +0000 Date: Sat, 9 Aug 2014 05:23:12 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11589) AccessControlException should be a not retriable exception MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11589?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D140= 91655#comment-14091655 ]=20 Hudson commented on HBASE-11589: -------------------------------- SUCCESS: Integrated in HBase-0.98 #443 (See [https://builds.apache.org/job/= HBase-0.98/443/]) HBASE-11589 AccessControlException should be a not retriable exception (Qia= ng Tian) (apurtell: rev 67c232326d16d64bbd7551ec2ef3c796f365d16e) * hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java * hbase-client/src/main/java/org/apache/hadoop/hbase/security/AccessDeniedE= xception.java > AccessControlException should be a not retriable exception > ---------------------------------------------------------- > > Key: HBASE-11589 > URL: https://issues.apache.org/jira/browse/HBASE-11589 > Project: HBase > Issue Type: Bug > Components: IPC/RPC > Affects Versions: 0.98.3 > Environment: SLES 11 SP1 > Reporter: Kashif J S > Assignee: Qiang Tian > Fix For: 0.99.0, 2.0.0, 0.98.6 > > Attachments: hbase-11589-master-v1.patch, hbase-11589-master-v2.p= atch, hbase-11589-master.patch > > > RPC server does not handle the AccessControlException thrown by authorize= Connection failure properly and in return sends IOException to the HBase cl= ient.=20 > Ultimately the client does retries and gets RetriesExhaustedException but= does not getting any link or information or stack trace about AccessContro= lException. > In short summary, upon inspection of RPCServer.java, it s= eems for the Listener, the Reader read code as below does not handle Access= ControlException > {noformat} > void doRead(=E2=80=A6. > =E2=80=A6.. > =E2=80=A6.. > try { > count =3D c.readAndProcess(); // This readAndProcess method throw= s AccessControlException from processOneRpc(byte[] buf) which is not handle= d ? > } catch (InterruptedException ieo) { > throw ieo; > } catch (Exception e) { > LOG.warn(getName() + ": count of bytes read: " + count, e); > count =3D -1; //so that the (count < 0) block is executed > } > {noformat} > Below is the client logs if authorizeConnection throws AccessControlExcep= tion: > 2014-07-24 19:40:58,768 INFO [main] client.HConnectionManager$HConnectio= nImplementation: getMaster attempt 7 of 7 failed; no more retrying. > com.google.protobuf.ServiceException: java.io.IOException: Call to host-1= 0-18-40-101/10.18.40.101:60000 failed on local exception: java.io.EOFExcept= ion > at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcCl= ient.java:1674) > at org.apache.hadoop.hbase.ipc.RpcClient$BlockingRpcChannelImplem= entation.callBlockingMethod(RpcClient.java:1715) > at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$Master= Service$BlockingStub.isMasterRunning(MasterProtos.java:42561) > at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionI= mplementation$MasterServiceStubMaker.isMasterRunning(HConnectionManager.jav= a:1688) > at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionI= mplementation$StubMaker.makeStubNoRetries(HConnectionManager.java:1597) > at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionI= mplementation$StubMaker.makeStub(HConnectionManager.java:1623) > at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionI= mplementation$MasterServiceStubMaker.makeStub(HConnectionManager.java:1677) > at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionI= mplementation.getKeepAliveMasterService(HConnectionManager.java:1885) > [...] > Caused by: java.io.IOException: Call to host-10-18-40-101/10.18.40.101:60= 000 failed on local exception: java.io.EOFException > at org.apache.hadoop.hbase.ipc.RpcClient.wrapException(RpcClient.= java:1485) > at org.apache.hadoop.hbase.ipc.RpcClient.call(RpcClient.java:1457= ) > at org.apache.hadoop.hbase.ipc.RpcClient.callBlockingMethod(RpcCl= ient.java:1657) > ... 254 more > Caused by: java.io.EOFException > at java.io.DataInputStream.readInt(DataInputStream.java:375) > at org.apache.hadoop.hbase.ipc.RpcClient$Connection.readResponse(= RpcClient.java:1072) > at org.apache.hadoop.hbase.ipc.RpcClient$Connection.run(RpcClient= .java:728) -- This message was sent by Atlassian JIRA (v6.2#6252)