Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 373C311A94 for ; Mon, 4 Aug 2014 18:22:13 +0000 (UTC) Received: (qmail 59857 invoked by uid 500); 4 Aug 2014 18:22:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 59824 invoked by uid 500); 4 Aug 2014 18:22:12 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 59807 invoked by uid 99); 4 Aug 2014 18:22:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Aug 2014 18:22:12 +0000 Date: Mon, 4 Aug 2014 18:22:12 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-11318) Classes in security subpackages missing @InterfaceAudience annotations. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-11318: ----------------------------------- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Committed to 0.98+ > Classes in security subpackages missing @InterfaceAudience annotations. > ----------------------------------------------------------------------- > > Key: HBASE-11318 > URL: https://issues.apache.org/jira/browse/HBASE-11318 > Project: HBase > Issue Type: Sub-task > Components: security > Affects Versions: 0.99.0, 0.96.1.1, 0.98.3 > Reporter: Jonathan Hsieh > Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11318_v2.patch, hbase-11318.patch > > > I was reading some of the security related code and noticed that many of the security related classes lack @InterfaceAudience markings. > WIth the current api I believe all but Permission should be Private. With the introduction of cell level ACL's Permission must be public because it is now exposed in the Mutation setACL calls[1]. > There is an inconsistency with the Mutation ACL -- the acl setters take Permission instances but the getter returns byte[]'s. As a follow on issue we could change the signature of Mutation.setACL so we don't have to expose the Permission class and convert it to be byte[], or change the getter to return an exposed Permission instance. > [1] http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/Mutation.html#setACL(java.util.Map) -- This message was sent by Atlassian JIRA (v6.2#6252)