Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 18 Aug 2014 21:21:21 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12715910.1400724001182.25941.1408396881016@arcas>
In-Reply-To: <JIRA.12715910.1400724001182@arcas>
References: <JIRA.12715910.1400724001182@arcas>
Subject: [jira] [Commented] (HBASE-11232) Region fail to release the
 updatelock for illegal CF in multi row mutations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101326#comment-14101326 ] 

Lars Hofhansl commented on HBASE-11232:
---------------------------------------

I'll take another look and then commit to 0.94.

> Region fail to release the updatelock for illegal CF in multi row mutations
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-11232
>                 URL: https://issues.apache.org/jira/browse/HBASE-11232
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.94.19
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>             Fix For: 0.94.23
>
>         Attachments: HBASE-11232-0.94.diff
>
>
> The failback code in processRowsWithLocks did not check the column family. If there is an illegal CF in the muation, it will  throw NullPointException and the update lock will not be released.  So the region can not be flushed and compacted. 
> HRegion #4946
> {code}
>         if (!mutations.isEmpty() && !walSyncSuccessful) {
>           LOG.warn("Wal sync failed. Roll back " + mutations.size() +
>               " memstore keyvalues for row(s):" +
>               processor.getRowsToLock().iterator().next() + "...");
>           for (KeyValue kv : mutations) {
>             stores.get(kv.getFamily()).rollback(kv);
>           }
>         }
>         // 11. Roll mvcc forward
>         if (writeEntry != null) {
>           mvcc.completeMemstoreInsert(writeEntry);
>           writeEntry = null;
>         }
>         if (locked) {
>           this.updatesLock.readLock().unlock();
>           locked = false;
>         }
> {code}


--
This message was sent by Atlassian JIRA
(v6.2#6252)