hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11835) Wrong managenement of non expected calls in the client
Date Thu, 28 Aug 2014 09:11:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113579#comment-14113579
] 

Nicolas Liochon commented on HBASE-11835:
-----------------------------------------

bq. Still, I'm going to manage this case as it is managed today. patch v2 is coming.
Hum, it adds some lines of code that do not seem necessary at the end: the probability to
purge/cancel the call and then receive a fatalConnection exception seems quite low, and the
impact is low as well: the connections will be close by any call that is not canceled or purged.
So I think I can stick to v1. You would be ok with this, [~ram_krish_86]? 

> Wrong managenement of non expected calls in the client
> ------------------------------------------------------
>
>                 Key: HBASE-11835
>                 URL: https://issues.apache.org/jira/browse/HBASE-11835
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.0.0, 2.0.0, 0.98.6
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 1.0.0, 2.0.0, 0.98.7
>
>         Attachments: rpcClient.patch
>
>
> If a call is purged or canceled we try to skip the reply from the server, but we read
the wrong number of bytes so we corrupt the tcp channel. It's hidden as it triggers retry
and so on, but it's bad for performances obviously.
> It happens with cell blocks.
> [~ram_krish_86], [~saint.ack@gmail.com], you know this part better than me, do you agree
with the analysis and the patch?
> The changes in rpcServer are not fully related: as the client close the connections in
such situation, I observed  both ClosedChannelException and CancelledKeyException. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message