hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
Date Tue, 26 Aug 2014 14:26:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110748#comment-14110748
] 

Carter commented on HBASE-11826:
--------------------------------

First question about this refactor:  _Deprecate the old methods or remove them entirely?_

One the one hand, deprecating them makes it easier for someone to move seamlessly to the new
interface.  On the other hand, this might muddy the new interface on day one.  If a user is
already putting in the effort to move to the new interface, shouldn't they just clean up these
method calls at the same time?

Thoughts?


> Split each tableOrRegionName admin methods into two targetted methods
> ---------------------------------------------------------------------
>
>                 Key: HBASE-11826
>                 URL: https://issues.apache.org/jira/browse/HBASE-11826
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Carter
>            Assignee: Carter
>
> Purpose of this is two implement [~enis]'s suggestion to strongly type the methods that
take "tableOrRegionName" as an argument.
> For instance:
> {code}
> void compact(final String tableNameOrRegionName)
> void compact(final byte[] tableNameOrRegionName)
> {code}
> becomes
> {code}
> @Deprecated
> void compact(final String tableNameOrRegionName)
> @Deprecated
> void compact(final byte[] tableNameOrRegionName)
> void compact(TableName table)
> void compactRegion(final byte[] regionName)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message