hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11821) [ImportTSV] Abstract labels tags creation into pluggable Interface
Date Tue, 26 Aug 2014 11:41:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110624#comment-14110624
] 

Hadoop QA commented on HBASE-11821:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12664374/HBASE-11821.patch
  against trunk revision .
  ATTACHMENT ID: 12664374

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +  public KeyValue create(byte[] row, int roffset, int rlength, byte[] family, int foffset,
int flength,
+  public KeyValue create(byte[] row, int roffset, int rlength, byte[] family, int foffset,
int flength,

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestClassFinder

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10587//console

This message is automatically generated.

> [ImportTSV] Abstract labels tags creation into pluggable Interface
> ------------------------------------------------------------------
>
>                 Key: HBASE-11821
>                 URL: https://issues.apache.org/jira/browse/HBASE-11821
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce, security
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.7
>
>         Attachments: HBASE-11821.patch
>
>
> HBASE-11553 abstracted out the VisibilityLabelService and using which one can go with
String based labels tags instead of default ordinal based. In MapReduce side, ImportTSV also
should support such an abstraction layer.  This is applicable for HFileOutputFormat where
mappers create Cells to be written to HFiles. 
> Also every Mapper (custom written also) dealing with such low level HBase things (Creation
of tags and Cells) is not a good idea. This issue plan to provide a public audience Facade
class to facilitate such Cell creation so that Mappers can just make use of them.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message