hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11812) duplicate code in SimpleRpcScheduler#SimpleRpcScheduler
Date Sat, 23 Aug 2014 11:15:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107966#comment-14107966
] 

Matteo Bertozzi commented on HBASE-11812:
-----------------------------------------

that doesn't look right to me, you are removing the compatibility with the old property name
the old property was called "ipc.xyz" (the one inside conf.get) the new one "hbase.ipc.xyz"
(the one in the constant)

> duplicate code in SimpleRpcScheduler#SimpleRpcScheduler
> -------------------------------------------------------
>
>                 Key: HBASE-11812
>                 URL: https://issues.apache.org/jira/browse/HBASE-11812
>             Project: HBase
>          Issue Type: Bug
>          Components: IPC/RPC
>    Affects Versions: 0.98.5
>            Reporter: Qiang Tian
>            Priority: Minor
>         Attachments: HBASE-11812-0.98.patch
>
>
> in 0.98.5 SimpleRpcScheduler#SimpleRpcScheduler:
> {code}
>      int maxQueueLength = conf.getInt(CALL_QUEUE_MAX_LENGTH_CONF_KEY,
>       conf.getInt("ipc.server.max.callqueue.length",
>         handlerCount * RpcServer.DEFAULT_MAX_CALLQUEUE_LENGTH_PER_HANDLER));
>   
>     float callqReadShare = conf.getFloat(CALL_QUEUE_READ_SHARE_CONF_KEY,
>       conf.getFloat("ipc.server.callqueue.read.share", 0));
>     float callQueuesHandlersFactor = conf.getFloat(CALL_QUEUE_HANDLER_FACTOR_CONF_KEY,
>       conf.getFloat("ipc.server.callqueue.handler.factor", 0));
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message