hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-11805) KeyValue to Cell Convert in WALEdit APIs
Date Tue, 26 Aug 2014 05:46:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110318#comment-14110318
] 

Anoop Sam John edited comment on HBASE-11805 at 8/26/14 5:45 AM:
-----------------------------------------------------------------

bq.We need the setter don't we?
Yes but with new Interface.   I was thinking initially to have an Interface extending Cell
and using that in server side.  But what u suggested looks better
bq.SequenceNumber (add setSequenceNumber to the SequenceNumber Interface) 

If the passed in Object is of type SequenceNumber  we can call setter directly. If not, there
is no other go but to recreate a KV and set seqNo 


was (Author: anoop.hbase):
bq.We need the setter don't we?
Yes but with new Interface.   I was thinking initially to have an Interface extending Cell
and using that in server side.  But what u suggested looks better
bq.SequenceNumber (add setSequenceNumber to the SequenceNumber Interface) 

> KeyValue to Cell Convert in WALEdit APIs
> ----------------------------------------
>
>                 Key: HBASE-11805
>                 URL: https://issues.apache.org/jira/browse/HBASE-11805
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>
> In almost all other main interface class/APIs we have changed KeyValue to Cell. But missing
in WALEdit. This is public marked for Replication (Well it should be for CP also) 
> These 2 APIs deal with KVs
> add(KeyValue kv)
> ArrayList<KeyValue> getKeyValues()
> Suggest deprecate them and add for 0.98
> add(Cell kv) 
> List<Cell> getCells()
> And just replace from 1.0



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message