hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11805) KeyValue to Cell Convert in WALEdit APIs
Date Tue, 26 Aug 2014 05:36:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110307#comment-14110307

Anoop Sam John commented on HBASE-11805:

bq.Man. Its a pity. Cell is all getters. Would be shame adding in this one setter. So, let
implementations implement Cell and SequenceNumber (add setSequenceNumber to the SequenceNumber
Interface) on the server side?
I was just saying the issues I met with once I change KV to Cell. :)  Not saying we should
add setter. I am also think that is not correct.  Sorry my statement was not clear.

bq.This is low-priority Anoop Sam John (as per Ram) because we are working on read-path first?
This is not just wrt offheap work.   WALEdit is exposed interface now. For Replication and
CP atleast. So I was thinking that we should finalize the API in that atleast before 1.0.

> KeyValue to Cell Convert in WALEdit APIs
> ----------------------------------------
>                 Key: HBASE-11805
>                 URL: https://issues.apache.org/jira/browse/HBASE-11805
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.6
> In almost all other main interface class/APIs we have changed KeyValue to Cell. But missing
in WALEdit. This is public marked for Replication (Well it should be for CP also) 
> These 2 APIs deal with KVs
> add(KeyValue kv)
> ArrayList<KeyValue> getKeyValues()
> Suggest deprecate them and add for 0.98
> add(Cell kv) 
> List<Cell> getCells()
> And just replace from 1.0

This message was sent by Atlassian JIRA

View raw message