hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11766) Backdoor CoprocessorHConnection is no longer being used for local writes
Date Mon, 25 Aug 2014 04:00:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108709#comment-14108709
] 

Andrew Purtell commented on HBASE-11766:
----------------------------------------

No there is no unit test. Looks like this was something rough committed by Jesse for Phoenix
back in September of 2013 and has escaped noticed by anyone else hence. We could throw together
a test coprocessor app to exercise this but that isn't verification of what Mujtaba observed
necessarily (if probably). Anyway, I'll circle back to this at some point.

> Backdoor CoprocessorHConnection is no longer being used for local writes
> ------------------------------------------------------------------------
>
>                 Key: HBASE-11766
>                 URL: https://issues.apache.org/jira/browse/HBASE-11766
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.4
>            Reporter: James Taylor
>            Assignee: Andrew Purtell
>              Labels: Phoenix
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: HBASE-11766.patch, HBASE-11766.patch
>
>
> There's a backdoor CoprocessorHConnection used to ensure that a batched mutation does
not go over the wire and back, but executes immediately locally. This is leveraged by Phoenix
during secondary index maintenance (for an ~20% perf improvement). It looks to me like it's
no longer used, as the following function is never invoked:
>   public org.apache.hadoop.hbase.protobuf.generated.ClientProtos.ClientService.BlockingInterface
>       getClient(ServerName serverName) throws IOException {
> It'd be good if feasible to add an HBase unit test to prevent further regressions. For
more info, see PHOENIX-1166.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message