hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey Zhong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11766) Backdoor CoprocessorHConnection is no longer being used for local writes
Date Sat, 23 Aug 2014 01:13:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107779#comment-14107779
] 

Jeffrey Zhong commented on HBASE-11766:
---------------------------------------

Looks good to me with one minor comment:
{quote}
+  public CoprocessorHConnection(Configuration conf, HRegionServer server) {
+    super(conf);
{quote}
Could we use parent HConnectionImplementation constructor {code}
HConnectionImplementation(Configuration conf, boolean managed,
        ExecutorService pool, User user);
{code} like {code} super(conf, false, null, user); {code}

> Backdoor CoprocessorHConnection is no longer being used for local writes
> ------------------------------------------------------------------------
>
>                 Key: HBASE-11766
>                 URL: https://issues.apache.org/jira/browse/HBASE-11766
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.4
>            Reporter: James Taylor
>            Assignee: Andrew Purtell
>              Labels: Phoenix
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: HBASE-11766.patch
>
>
> There's a backdoor CoprocessorHConnection used to ensure that a batched mutation does
not go over the wire and back, but executes immediately locally. This is leveraged by Phoenix
during secondary index maintenance (for an ~20% perf improvement). It looks to me like it's
no longer used, as the following function is never invoked:
>   public org.apache.hadoop.hbase.protobuf.generated.ClientProtos.ClientService.BlockingInterface
>       getClient(ServerName serverName) throws IOException {
> It'd be good if feasible to add an HBase unit test to prevent further regressions. For
more info, see PHOENIX-1166.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message