hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11733) Avoid copy-paste in Master/Region CoprocessorHost
Date Fri, 15 Aug 2014 18:41:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098907#comment-14098907
] 

Gary Helmling commented on HBASE-11733:
---------------------------------------

+1 on v2 plus additional {{coprocessors.isEmpty()}} check.  This will be a net gain when no
coprocessors are installed (no iterator instantiated) and we get the added maintainability
for free.  Nice work!

> Avoid copy-paste in Master/Region CoprocessorHost
> -------------------------------------------------
>
>                 Key: HBASE-11733
>                 URL: https://issues.apache.org/jira/browse/HBASE-11733
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11733-0.98-v1.patch, HBASE-11733-v0.patch, HBASE-11733-v2.patch
>
>
> all the methods of MasterCoprocessorHost and RegionCoprocessorHost are copy-paste, and
a couple of them have some missing fixes.
> The body of each function is the same, the only difference is the call to the specific
coprocessor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message