hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11733) Avoid copy-paste in Master/Region CoprocessorHost
Date Thu, 14 Aug 2014 16:46:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097189#comment-14097189
] 

Matteo Bertozzi commented on HBASE-11733:
-----------------------------------------

yeah just to follow up with some numbers, reflection is too expensive while the new Interface()
takes only few nanoseconds per call. I've tested it with jit disabled calling the direct method
vs calling a method with the interface that calls the direct method.. and by dividing the
total time by the numbers of call I'm around 20nanosec.

> Avoid copy-paste in Master/Region CoprocessorHost
> -------------------------------------------------
>
>                 Key: HBASE-11733
>                 URL: https://issues.apache.org/jira/browse/HBASE-11733
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11733-0.98-v1.patch, HBASE-11733-v0.patch
>
>
> all the methods of MasterCoprocessorHost and RegionCoprocessorHost are copy-paste, and
a couple of them have some missing fixes.
> The body of each function is the same, the only difference is the call to the specific
coprocessor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message