hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11713) Adding hbase shell unit test coverage for visibility labels.
Date Mon, 11 Aug 2014 17:32:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093023#comment-14093023
] 

Andrew Purtell commented on HBASE-11713:
----------------------------------------

New tests look good.

{code}
@@ -51,8 +53,14 @@ public class TestShell {
     TEST_UTIL.getConfiguration().setInt("hbase.client.pause", 250);
     TEST_UTIL.getConfiguration().setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 6);
     TEST_UTIL.getConfiguration().setBoolean(CoprocessorHost.ABORT_ON_ERROR_KEY, false);
+    TEST_UTIL.getConfiguration().setInt("hfile.format.version", 3);
     // Security setup configuration
     SecureTestUtil.enableSecurity(TEST_UTIL.getConfiguration());
+    Configuration conf = TEST_UTIL.getConfiguration();
+    append(TEST_UTIL.getConfiguration(), "hbase.coprocessor.master.classes",
+      VisibilityController.class.getName());
+    append(TEST_UTIL.getConfiguration(), "hbase.coprocessor.region.classes",
+      VisibilityController.class.getName());
 
     TEST_UTIL.startMiniCluster();
{code}

enableSecurity will set up for using HFile v3.

There was a test utility static helper method committed to the visibility package recently
for setting up visibility related coprocessors. Maybe that could be modified rather than specifying
VisibilityController by name here?



> Adding hbase shell unit test coverage for visibility labels.
> ------------------------------------------------------------
>
>                 Key: HBASE-11713
>                 URL: https://issues.apache.org/jira/browse/HBASE-11713
>             Project: HBase
>          Issue Type: Test
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-11713.patch
>
>
> Adding test coverage for visibility labels to hbase shell. Also, refactoring existing
tests so that all the unit tests related to visibility can be found in one place.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message