hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11685) Incr/decr on the reference count of HConnectionImplementation need be atomic
Date Thu, 07 Aug 2014 19:06:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089623#comment-14089623
] 

Andrew Purtell commented on HBASE-11685:
----------------------------------------

There's a spelling error in the log message. Please change "nagative" to "negative". Is there
any way to identify for which connection the ref count went negative? Would aid in debugging.
Otherwise lgtm. 



> Incr/decr on the reference count of HConnectionImplementation need be atomic 
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-11685
>                 URL: https://issues.apache.org/jira/browse/HBASE-11685
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11685-trunk-v1.diff, HBASE-11685-trunk-v2.diff, HBASE-11685-trunk-v3.diff
>
>
> Currently, the incr/decr operation on the ref count of HConnectionImplementation are
not atomic. This may cause that the ref count always be larger than 0 and  the connection
never be closed.
> {code}
>     /**
>      * Increment this client's reference count.
>      */
>     void incCount() {
>       ++refCount;
>     }
>     /**
>      * Decrement this client's reference count.
>      */
>     void decCount() {
>       if (refCount > 0) {
>         --refCount;
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message