hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11679) Replace "HTable" with "HTableInterface" where backwards-compatible
Date Tue, 05 Aug 2014 22:43:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086924#comment-14086924
] 

Hadoop QA commented on HBASE-11679:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12659951/HBASE_11679.patch
  against trunk revision .
  ATTACHMENT ID: 12659951

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 444 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +  public static void addRegionToMeta(HTableInterface meta, HRegionInfo regionInfo) throws
IOException {
+      final HTableInterface table, final ColumnInterpreter<R, S, P, Q, T> ci, Scan
scan) throws Throwable {
+      final HTableInterface table, ColumnInterpreter<R, S, P, Q, T> ci, Scan scan)
throws Throwable {
+  public int loadTable(final HTableInterface t, final byte[] f, boolean writeToWAL) throws
IOException {
+    HTableInterface table = TEST_UTIL.createTable(Bytes.toBytes("testRowsPutBufferedManyManyFlushes"),
+  private Map<byte [], String> hello(final HTableInterface table, final String send,
final String response)
+        HTableInterface acl = new HTable(util.getConfiguration(), AccessControlLists.ACL_TABLE_NAME);
+        HTableInterface acl = new HTable(util.getConfiguration(), AccessControlLists.ACL_TABLE_NAME);
+        HTableInterface acl = new HTable(util.getConfiguration(), AccessControlLists.ACL_TABLE_NAME);
+        HTableInterface acl = new HTable(util.getConfiguration(), AccessControlLists.ACL_TABLE_NAME);

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestIOFencing
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence
                  org.apache.hadoop.hbase.regionserver.TestRegionReplicas
                  org.apache.hadoop.hbase.client.TestReplicasClient
                  org.apache.hadoop.hbase.master.TestRestartCluster
                  org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10304//console

This message is automatically generated.

> Replace "HTable" with "HTableInterface" where backwards-compatible
> ------------------------------------------------------------------
>
>                 Key: HBASE-11679
>                 URL: https://issues.apache.org/jira/browse/HBASE-11679
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Carter
>            Assignee: Carter
>         Attachments: HBASE_11679.patch
>
>
> This is a refactor to move more of the code towards using interfaces for proper encapsulation
of logic.
> The amount of code touched is large, but it should be fairly easy to review.  It changes
variable declarations from HTable to HTableInterface where the following holds:
> # The declaration being updated won't break assignment
> # The declaration change does not break the compile (eg trying to access non-interface
methods)
> The two main situations are to change something like this:
> {code}
> HTable h = new HTable(c, tn);
> {code}
> to
> {code}
> HTableInterface h = new HTable(c, tn);
> {code}
> and this:
> {code}
> public void doSomething(HTable h) { ... }
> {code}
> to this:
> {code}
> public void doSomething(HTableInterface h) { ... }
> {code}
> This gets most of the obvious cases out of the way and prepares for more complicated
interface refactors in the future.  In method signatures, I changed parameters, but did _not_
change any public or protected method return values, since that would violate criteria #1
above and break compatibility.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message