hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11648) Typo of config: hbase.hstore.compaction.ratio in book.xml
Date Fri, 01 Aug 2014 15:36:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082352#comment-14082352
] 

Hadoop QA commented on HBASE-11648:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12659142/HBASE-11648-trunk-v1.diff
  against trunk revision .
  ATTACHMENT ID: 12659142

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestRollingRestart
                  org.apache.hadoop.hbase.regionserver.TestRegionReplicas
                  org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
                  org.apache.hadoop.hbase.master.TestRestartCluster
                  org.apache.hadoop.hbase.client.TestReplicasClient
                  org.apache.hadoop.hbase.TestIOFencing

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s): 	at org.apache.hadoop.hbase.master.TestRollingRestart.testBasicRollingRestart(TestRollingRestart.java:140)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10264//console

This message is automatically generated.

> Typo of config: hbase.hstore.compaction.ratio in book.xml
> ---------------------------------------------------------
>
>                 Key: HBASE-11648
>                 URL: https://issues.apache.org/jira/browse/HBASE-11648
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 1.0.0
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: HBASE-11648-trunk-v1.diff
>
>
> When looking at the parameters used by compaction algorithm in http://hbase.apache.org/book/regions.arch.html,
we found there is typo.
> In hbase code, the config key for compaction ratio is hbase.hstore.compaction.ratio.
> But in the hbase book it's hbase.store.compaction.ratio.
> CompactSelection.java#66
> {code}
>     this.conf = conf;
>     this.compactRatio = conf.getFloat("hbase.hstore.compaction.ratio", 1.2F);
>     this.compactRatioOffPeak = conf.getFloat("hbase.hstore.compaction.ratio.offpeak",
5.0F);
> {code}
> Just fix it to avoid misleading.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message