hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ryan rawson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11567) Write bulk load events to WAL
Date Wed, 06 Aug 2014 21:55:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088336#comment-14088336

ryan rawson commented on HBASE-11567:

JMock has a few features that helps us keep our tests clean.  First it only mocks interfaces,
encouraging good interface-driven design.  Secondly JMock has a nice little mini DSL which
reads nicely.  Lastly, JMock is a very strict mocker, it doesnt requires a separate validation
step and requires complete specification of dependent calls.

Mockito and JMock are slightly different tools, and have their purposes each.  I'd prefer
new tests be done with JMock, and using mockito to leverage older code into a newer style
over time.

Since the dependency is test-only, there is no run-time impact.

> Write bulk load events to WAL
> -----------------------------
>                 Key: HBASE-11567
>                 URL: https://issues.apache.org/jira/browse/HBASE-11567
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Alex Newman
>         Attachments: HBASE-11567-v1.patch, HBASE-11567-v2.patch
> Similar to writing flush (HBASE-11511), compaction(HBASE-2231) to WAL and region open/close
(HBASE-11512) , we should persist bulk load events to WAL.
> This is especially important for secondary region replicas, since we can use this information
to pick up primary regions' files from secondary replicas.
> A design doc for secondary replica replication can be found at HBASE-11183.

This message was sent by Atlassian JIRA

View raw message