hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11550) Bucket sizes passed through BUCKET_CACHE_BUCKETS_KEY should be validated
Date Wed, 13 Aug 2014 15:36:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095592#comment-14095592
] 

Ted Yu commented on HBASE-11550:
--------------------------------

{code}
-    void reconfigure(int sizeIndex, int[] bucketSizes, long bucketCapacity) {
-      Preconditions.checkElementIndex(sizeIndex, bucketSizes.length);
+    void reconfigure(int sizeIndex, List<Integer> bucketSizes, long bucketCapacity)
{
{code}
Consider using http://docs.oracle.com/javase/7/docs/api/java/util/Arrays.html#sort(int[])
so that the number of changes in the patch comes down.

> Bucket sizes passed through BUCKET_CACHE_BUCKETS_KEY should be validated
> ------------------------------------------------------------------------
>
>                 Key: HBASE-11550
>                 URL: https://issues.apache.org/jira/browse/HBASE-11550
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Gustavo Anatoly
>         Attachments: HBASE-11550-v1.patch, HBASE-11550-v2.patch, HBASE-11550-v3.patch,
HBASE-11550.patch
>
>
> User can pass bucket sizes through "hbase.bucketcache.bucket.sizes" config entry.
> The sizes are supposed to be in increasing order. Validation should be added in CacheConfig#getL2().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message