hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11550) Custom value for BUCKET_CACHE_BUCKETS_KEY should be sorted
Date Mon, 18 Aug 2014 19:21:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101124#comment-14101124
] 

stack commented on HBASE-11550:
-------------------------------

bq. I don't think it fair to the new contributor to have their contributions get caught up
in the project politicking.

[~gustavoanatoly] To be clear, ill-defined JIRAs consume the attention of those who are trying
to follow along. Lack of clarity in the definition requires we need to keep an active eye
out. When the issue is trivial, this is particularly irksome.

This issue is a good example.  It starts out without provenance -- does the issue come of
'code-reading', testing?, a user reported issue?, an attempt at setting bucket sizes in configs
-- and it has 'shoulds' and 'supposed to' in subject and original description but there is
no justification as to why. Nick, a third party altogether, has to do detective work to elicit
there is an actual problem here.

For another example, see the follow-on, filed again by Ted assigned to you, HBASE-11743. 
Look at it. It says this issue, HBASE-11550, makes it "...such that there is no wastage in
bucket allocation". But Nick resolves this issue with the comment that your patch ensures
default and user-supplied config align punting on the wastage question... to he 'guesses'
HBASE-11743. This is lack of alignment here. The mess that is this issue looks like it is
to repeat over in HBASE-11743.

To avoid any crossfire in the future, I'd suggest file your own issues especially if you are
trying to build yourself a bit of a track record. Also work on non-trivial issues as said
before.  You will find it easier getting reviewers if the issue is non-trivial.

> Custom value for BUCKET_CACHE_BUCKETS_KEY should be sorted
> ----------------------------------------------------------
>
>                 Key: HBASE-11550
>                 URL: https://issues.apache.org/jira/browse/HBASE-11550
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0, 0.98.4, 0.98.5
>            Reporter: Ted Yu
>            Assignee: Gustavo Anatoly
>            Priority: Trivial
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: HBASE-11550-v1.patch, HBASE-11550-v2.patch, HBASE-11550-v3.patch,
HBASE-11550-v4-0.98.patch, HBASE-11550-v4.patch, HBASE-11550.patch
>
>
> User can pass bucket sizes through "hbase.bucketcache.bucket.sizes" config entry.
> The sizes are supposed to be in increasing order. Validation should be added in CacheConfig#getL2().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message