hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11318) Classes in security subpackages missing @InterfaceAudience annotations.
Date Mon, 04 Aug 2014 17:06:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084895#comment-14084895

Andrew Purtell commented on HBASE-11318:

Last chance for a review and +1 before moving out of .5. Ping [~jmhsieh], [~stack], should
only take a few moments. 

> Classes in security subpackages missing @InterfaceAudience annotations.
> -----------------------------------------------------------------------
>                 Key: HBASE-11318
>                 URL: https://issues.apache.org/jira/browse/HBASE-11318
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.99.0,, 0.98.3
>            Reporter: Jonathan Hsieh
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 0.98.5, 2.0.0
>         Attachments: HBASE-11318_v2.patch, hbase-11318.patch
> I was reading some of the security related code and noticed that many of the security
related classes lack @InterfaceAudience markings.
> WIth the current api I believe all but Permission should be Private.  With the introduction
of cell level ACL's Permission must be public because it is now exposed in the Mutation setACL
> There is an inconsistency with the Mutation ACL -- the acl setters take Permission instances
but the getter returns byte[]'s.  As a follow on issue we could change the signature of Mutation.setACL
so we don't have to expose the Permission class and convert it to be byte[], or change the
getter to return an exposed Permission instance.
> [1] http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/Mutation.html#setACL(java.util.Map)

This message was sent by Atlassian JIRA

View raw message