hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Newman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10092) Move up on to log4j2
Date Mon, 25 Aug 2014 22:54:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109914#comment-14109914
] 

Alex Newman commented on HBASE-10092:
-------------------------------------

I have attached a preview patch to keep this up to date. You can follow my realtime progress
at
https://github.com/OhmData/hbase-public/tree/10092

Overall, there's a bunch of stuff I want feedback on.

1 -  What is the purpose of setting the request logger? Setting appenders is a bit more difficult
to do in the new log4j2. Perhaps we would be better just upgrading to jetty 9 and using the
built in capability. Another option may be using routing.
2 - [~apurtell] Why did you leave in the log4j v1 stuff. Is the compatibility the useful part.
What am I missing?


> Move up on to log4j2
> --------------------
>
>                 Key: HBASE-10092
>                 URL: https://issues.apache.org/jira/browse/HBASE-10092
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: Alex Newman
>             Fix For: 2.0.0
>
>         Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  This rather
radical transition can be done w/ minor change given they have an adapter for apache's logging,
the one we use.  They also have and adapter for slf4j so we likely can remove at least some
of the 4 versions of this module our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency resolve hell
courtesy of our slf4j.  Fixing will take some concentration and a good net connection, an
item I currently lack.  Other TODOs are that will need to fix our little log level setting
jsp page -- will likely have to undo our use of hadoop's tool here -- and the config system
changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message