hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9741) Remove hbase.regions.slop from hbase-default.xml
Date Mon, 25 Aug 2014 18:18:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109441#comment-14109441
] 

Jonathan Hsieh commented on HBASE-9741:
---------------------------------------

Something doesn't make sense, why does TestRegionRebalancing break with the values is removed
from the conf?   Do you have an explanation [~eclark], [~ranjana_rajendran]?  (is this the
expect thing that makes this confusing or was this unexpected?)

{coe}diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java
index fdcb00c..9252da9 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java
@@ -165,7 +165,8 @@ public class TestRegionRebalancing {
     // TODO: Fix this test.  Old balancer used to run with 'slop'.  New
     // balancer does not.
     boolean success = false;
-    float slop = (float)UTIL.getConfiguration().getFloat("hbase.regions.slop", 0.1f);
+    float slop = (float)UTIL.getConfiguration().getFloat(HConstants.LOAD_BALANCER_SLOP_KEY,
0.2f);
+    
     if (slop <= 0) slop = 1;
 
     for (int i = 0; i < 5; i++) {
{code}

> Remove hbase.regions.slop from hbase-default.xml
> ------------------------------------------------
>
>                 Key: HBASE-9741
>                 URL: https://issues.apache.org/jira/browse/HBASE-9741
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Elliott Clark
>              Labels: beginner
>         Attachments: HBASE-9741-v0.patch, HBASE-9741-v1.patch, HBASE-9741-v3.patch, HBASE-9741-v4.patch
>
>
> Different balancers have different slop default values.  We should remove hbase.regions.slop
from hbase-default.xml



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message