Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 23 Jul 2014 14:32:40 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12728460.1405912837896.29082.1406125960347@arcas>
In-Reply-To: <JIRA.12728460.1405912837896@arcas>
References: <JIRA.12728460.1405912837896@arcas>
Subject: [jira] [Commented] (HBASE-11551) BucketCache$WriterThread.run()
 doesn't handle exceptions correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HBASE-11551?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D140=
71780#comment-14071780 ]=20

stack commented on HBASE-11551:
-------------------------------

bq. The above exception =E2=80=98Failed allocating for block bck2_0=E2=80=
=99 won't cause writerThread exiting.

So, the issue is your observation [~zjushch] but [~ted_yu] files it and add=
s the patch?  Then [~ted_yu] posts justification for the patch but the patc=
h does not address the justification?

[~ted_yu] where does the posted exception come from?  We should fix it.

> BucketCache$WriterThread.run() doesn't handle exceptions correctly
> ------------------------------------------------------------------
>
>                 Key: HBASE-11551
>                 URL: https://issues.apache.org/jira/browse/HBASE-11551
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 11551-v1.txt
>
>
> Currently the catch is outside the while loop:
> {code}
>       try {
>         while (cacheEnabled && writerEnabled) {
> ...
>       } catch (Throwable t) {
>         LOG.warn("Failed doing drain", t);
>       }
> {code}
> When exception (e.g. BucketAllocatorException) is thrown, run() method wo=
uld terminate, silently.


--
This message was sent by Atlassian JIRA
(v6.2#6252)