Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5779D10F5E for ; Wed, 16 Jul 2014 21:09:07 +0000 (UTC) Received: (qmail 12213 invoked by uid 500); 16 Jul 2014 21:09:07 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 12172 invoked by uid 500); 16 Jul 2014 21:09:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 12159 invoked by uid 99); 16 Jul 2014 21:09:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Jul 2014 21:09:07 +0000 Date: Wed, 16 Jul 2014 21:09:07 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11520) Simplify offheap cache config by removing the confusing "hbase.bucketcache.percentage.in.combinedcache" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064099#comment-14064099 ] stack commented on HBASE-11520: ------------------------------- We should probably drop config'ing direct max memory in hbase-env.sh since in jdk7 there is no limit (to be confirmed). > Simplify offheap cache config by removing the confusing "hbase.bucketcache.percentage.in.combinedcache" > ------------------------------------------------------------------------------------------------------- > > Key: HBASE-11520 > URL: https://issues.apache.org/jira/browse/HBASE-11520 > Project: HBase > Issue Type: Sub-task > Components: io > Affects Versions: 0.99.0 > Reporter: stack > Assignee: stack > Fix For: 0.99.0, 2.0.0 > > Attachments: 11520.txt, 11520v2.txt, 11520v3.txt, 11520v3.txt > > > Remove "hbase.bucketcache.percentage.in.combinedcache". It is unnecessary complication of block cache config. Let L1 config setup be as it is whether a L2 present or not, just set hfile.block.cache.size (not hbase.bucketcache.size * (1.0 - hbase.bucketcache.percentage.in.combinedcache)). For L2, let hbase.bucketcache.size be the actual size of the bucket cache, not hbase.bucketcache.size * hbase.bucketcache.percentage.in.combinedcache. > Attached patch removes the config. and updates docs. Adds tests to confirm configs are as expected whether a CombinedBlockCache deploy or a strict L1+L2 deploy. -- This message was sent by Atlassian JIRA (v6.2#6252)