Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4882116AF for ; Mon, 14 Jul 2014 05:34:04 +0000 (UTC) Received: (qmail 68719 invoked by uid 500); 14 Jul 2014 05:34:04 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 68679 invoked by uid 500); 14 Jul 2014 05:34:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68666 invoked by uid 99); 14 Jul 2014 05:34:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Jul 2014 05:34:04 +0000 Date: Mon, 14 Jul 2014 05:34:04 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11442) ReplicationSourceManager doesn't cleanup the queues for recovered sources MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060353#comment-14060353 ] Andrew Purtell commented on HBASE-11442: ---------------------------------------- Skimmed the patch, +1 for 0.98 > ReplicationSourceManager doesn't cleanup the queues for recovered sources > ------------------------------------------------------------------------- > > Key: HBASE-11442 > URL: https://issues.apache.org/jira/browse/HBASE-11442 > Project: HBase > Issue Type: Bug > Components: Replication > Reporter: Virag Kothari > Assignee: Virag Kothari > Attachments: HBASE-11442.patch, HBASE-11442_2.patch > > > Currently, ReplicationSourceManager only cleanups the queues for recovered sources when the queue is being closed. This can cause the already read WAL's files to be read again when a region server doing failover also dies. This can cause replication to possibly happen again > For e.g lets say RS1 dies with 5 files in queue and RS2 is doing the failover. Now, lets say RS2 dies after going thru 3 files in queue and RS3 is doing the failover. In this case, RS3 will again read those 3 files as they were not removed from the queue. (Though it will read the first file from the set pos. in ZK) -- This message was sent by Atlassian JIRA (v6.2#6252)